Skip to content

fix branch name #58132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix branch name #58132

merged 2 commits into from
Nov 14, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 7, 2023

fix the branch name of the workflow

@sokra sokra requested review from a team as code owners November 7, 2023 11:20
@sokra sokra requested review from ismaelrumzan and steven-tey and removed request for a team November 7, 2023 11:20
@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Nov 7, 2023
@ijjk
Copy link
Member

ijjk commented Nov 7, 2023

Failing test suites

Commit: 1980034

pnpm test-dev test/development/acceptance/ReactRefreshLogBox-builtins.test.ts

  • ReactRefreshLogBox default > Module not found (missing global CSS)
Expand output

● ReactRefreshLogBox default › Module not found (missing global CSS)

expect(received).toContain(expected) // indexOf

Expected substring: "index page"
Received string:    "<head><meta charset=\"utf-8\"><meta name=\"viewport\" content=\"width=device-width\"><meta name=\"next-head-count\" content=\"2\"><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/_next/static/chunks/polyfills.js?ts=1699356430487\"></script><script src=\"/_next/static/chunks/fallback/webpack.js?ts=1699356430487\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/main.js?ts=1699356430487\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/pages/_app.js?ts=1699356430487\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/pages/_error.js?ts=1699356430487\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body style=\"overflow: hidden;\"><div id=\"__next\"></div><script src=\"/_next/static/chunks/fallback/react-refresh.js?ts=1699356430487\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"isFallback\":false,\"err\":{\"name\":\"Error\",\"source\":\"server\",\"message\":\"Module not found: Can't resolve './non-existent.css'\\n\\u003e 1 | import './non-existent.css'\\n  2 |\\n  3 | export default function App({ Component, pageProps }) {\\n  4 |   return \\u003cComponent {...pageProps} /\\u003e\\n\\nhttps://nextjs.org/docs/messages/module-not-found\\n\",\"stack\":\"Error: Module not found: Can't resolve './non-existent.css'\\n\\u001b[0m\\u001b[31m\\u001b[1m\\u003e\\u001b[22m\\u001b[39m\\u001b[90m 1 |\\u001b[39m \\u001b[36mimport\\u001b[39m \\u001b[32m'./non-existent.css'\\u001b[39m\\u001b[0m\\n\\u001b[0m \\u001b[90m 2 |\\u001b[39m\\u001b[0m\\n\\u001b[0m \\u001b[90m 3 |\\u001b[39m \\u001b[36mexport\\u001b[39m \\u001b[36mdefault\\u001b[39m \\u001b[36mfunction\\u001b[39m \\u001b[33mApp\\u001b[39m({ \\u001b[33mComponent\\u001b[39m\\u001b[33m,\\u001b[39m pageProps }) {\\u001b[0m\\n\\u001b[0m \\u001b[90m 4 |\\u001b[39m   \\u001b[36mreturn\\u001b[39m \\u001b[33m\\u003c\\u001b[39m\\u001b[33mComponent\\u001b[39m {\\u001b[33m...\\u001b[39mpageProps} \\u001b[33m/\\u001b[39m\\u001b[33m\\u003e\\u001b[39m\\u001b[0m\\n\\nhttps://nextjs.org/docs/messages/module-not-found\\n\\n    at getNotFoundError (/tmp/next-install-5a634825f4399d7108ecf417578194cbe1d98434698b3eb7a846bb58cf4af083/node_modules/.pnpm/file+..+next-repo-b93c27ccca7e3810b68ca9020bd2406ea6c2711491ca1b0e0ce587c0122287ce+packages+n_pja2dbc6euow5nejrxiairdorm/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/parseNotFoundError.js:120:16)\\n    at async getModuleBuildError (/tmp/next-install-5a634825f4399d7108ecf417578194cbe1d98434698b3eb7a846bb58cf4af083/node_modules/.pnpm/file+..+next-repo-b93c27ccca7e3810b68ca9020bd2406ea6c2711491ca1b0e0ce587c0122287ce+packages+n_pja2dbc6euow5nejrxiairdorm/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/webpackModuleError.js:102:27)\\n    at async /tmp/next-install-5a634825f4399d7108ecf417578194cbe1d98434698b3eb7a846bb58cf4af083/node_modules/.pnpm/file+..+next-repo-b93c27ccca7e3810b68ca9020bd2406ea6c2711491ca1b0e0ce587c0122287ce+packages+n_pja2dbc6euow5nejrxiairdorm/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/index.js:29:49\\n    at async Promise.all (index 0)\\n    at async /tmp/next-install-5a634825f4399d7108ecf417578194cbe1d98434698b3eb7a846bb58cf4af083/node_modules/.pnpm/file+..+next-repo-b93c27ccca7e3810b68ca9020bd2406ea6c2711491ca1b0e0ce587c0122287ce+packages+n_pja2dbc6euow5nejrxiairdorm/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/index.js:27:21\"},\"gip\":true,\"scriptLoader\":[]}</script><div id=\"__next-build-watcher\" style=\"position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;\"></div><next-route-announcer><p aria-live=\"assertive\" id=\"__next-route-announcer__\" role=\"alert\" style=\"border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; top: 0px; width: 1px; white-space: nowrap; overflow-wrap: normal;\"></p></next-route-announcer><nextjs-portal></nextjs-portal></body>"

  182 |     expect(
  183 |       await session.evaluate(() => document.documentElement.innerHTML)
> 184 |     ).toContain('index page')
      |       ^
  185 |
  186 |     await cleanup()
  187 |   })

  at Object.toContain (development/acceptance/ReactRefreshLogBox-builtins.test.ts:184:7)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Nov 7, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/fix-branch-name Change
buildDuration 10.7s 10.8s ⚠️ +139ms
buildDurationCached 6.1s 6.8s ⚠️ +708ms
nodeModulesSize 175 MB 175 MB ✓
nextStartRea..uration (ms) 406ms 421ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/fix-branch-name Change
199-HASH.js gzip 30.4 kB 30.5 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB ✓
494.HASH.js gzip 182 B 182 B ✓
framework-HASH.js gzip 45.5 kB 45.5 kB ✓
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33 kB 33 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/fix-branch-name Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/fix-branch-name Change
_app-HASH.js gzip 205 B 205 B ✓
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 505 B 507 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.71 kB 2.7 kB N/A
routerDirect..HASH.js gzip 318 B 318 B ✓
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 319 B 320 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 885 B 885 B ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/fix-branch-name Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/fix-branch-name Change
index.html gzip 529 B 526 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/fix-branch-name Change
edge-ssr.js gzip 96.8 kB 96.8 kB N/A
page.js gzip 151 kB 151 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/fix-branch-name Change
middleware-b..fest.js gzip 625 B 627 B N/A
middleware-r..fest.js gzip 148 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB ✓
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 26.7 kB 26.7 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js sokra/fix-branch-name Change
app-page-exp...dev.js gzip 165 kB 165 kB ✓
app-page-exp..prod.js gzip 92.2 kB 92.2 kB ✓
app-page-tur..prod.js gzip 93 kB 93 kB ✓
app-page-tur..prod.js gzip 87.7 kB 87.7 kB ✓
app-page.run...dev.js gzip 135 kB 135 kB ✓
app-page.run..prod.js gzip 87 kB 87 kB ✓
app-route-ex...dev.js gzip 23.5 kB 23.5 kB ✓
app-route-ex..prod.js gzip 16.4 kB 16.4 kB ✓
app-route-tu..prod.js gzip 16.4 kB 16.4 kB ✓
app-route-tu..prod.js gzip 16 kB 16 kB ✓
app-route.ru...dev.js gzip 22.9 kB 22.9 kB ✓
app-route.ru..prod.js gzip 16 kB 16 kB ✓
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB ✓
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.5 kB 21.5 kB ✓
pages.runtim...dev.js gzip 22.2 kB 22.2 kB ✓
pages.runtim..prod.js gzip 21.5 kB 21.5 kB ✓
server.runti..prod.js gzip 48.5 kB 48.5 kB ✓
Overall change 913 kB 913 kB ✓
Commit: 1980034

@sokra sokra requested a review from timneutkens November 8, 2023 07:04
@luismulinari luismulinari mentioned this pull request Nov 8, 2023
Merged
@sokra sokra merged commit bcd0cb8 into canary Nov 14, 2023
@sokra sokra deleted the sokra/fix-branch-name branch November 14, 2023 10:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan was automatically assigned from vercel/devex

@steven-tey steven-tey Awaiting requested review from steven-tey steven-tey was automatically assigned from vercel/devex

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sokra @ijjk