Skip to content

examples: migrate with-elasticsearch to TypeScript #44842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2023
Merged

examples: migrate with-elasticsearch to TypeScript #44842

merged 4 commits into from
Jun 15, 2023

Conversation

@valentinpolitov
Copy link
Contributor

@valentinpolitov valentinpolitov commented Jan 13, 2023

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue was opened via the examples template. label Jan 13, 2023
@ijjk ijjk requested a review from jankaifer as a code owner March 2, 2023 23:39
@ijjk ijjk requested a review from a team as a code owner May 4, 2023 16:19
balazsorban44
balazsorban44 reviewed Jun 15, 2023
View reviewed changes
balazsorban44
balazsorban44 reviewed Jun 15, 2023
View reviewed changes
@kodiakhq kodiakhq bot merged commit 5b268be into vercel:canary Jun 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@jankaifer jankaifer Awaiting requested review from jankaifer

Assignees

No one assigned

Labels

examples Issue was opened via the examples template. locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valentinpolitov @balazsorban44 @ijjk