Skip to content

Inline styles for better performance #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Inline styles for better performance #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbf65ec
Inline styles for better performance
cramforce Jul 19, 2024
f2ae1f0
Optimize images
cramforce Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions app/globals.css
View file
Open in desktop

This file was deleted.

28 changes: 15 additions & 13 deletions app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
import { CartCountProvider } from '#/components/cart-count-context';
import { Header } from '#/components/header';
import { Sidebar } from '#/components/sidebar';
import { GeistSans } from 'geist/font/sans';
import { Metadata } from 'next';
import './globals.css';
import { CartCountProvider } from "#/components/cart-count-context";
import { Header } from "#/components/header";
import { Sidebar } from "#/components/sidebar";
import { Metadata } from "next";
import { GlobalStyles } from "./styles";

export const metadata: Metadata = {
metadataBase: new URL('https://partialprerendering.com'),
title: 'Next.js Partial Prerendering',
description: 'A demo of Next.js using Partial Prerendering.',
metadataBase: new URL("https://partialprerendering.com"),
title: "Next.js Partial Prerendering",
description: "A demo of Next.js using Partial Prerendering.",
openGraph: {
title: 'Next.js Partial Prerendering',
description: 'A demo of Next.js using Partial Prerendering.',
title: "Next.js Partial Prerendering",
description: "A demo of Next.js using Partial Prerendering.",
},
twitter: {
card: 'summary_large_image',
card: "summary_large_image",
},
};

Expand All @@ -24,7 +23,10 @@ export default function RootLayout({
children: React.ReactNode;
}) {
return (
<html lang="en" className={`[color-scheme:dark] ${GeistSans.variable}`}>
<html lang="en" className={`[color-scheme:dark]`}>
<head>
<GlobalStyles />
</head>
<body className="overflow-y-scroll bg-gray-1100 bg-[url('/grid.svg')] pb-36">
<Sidebar />
<div className="lg:pl-72">
Expand Down
13 changes: 13 additions & 0 deletions app/styles.tsx
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions components/single-product.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { Pricing } from '#/components/pricing';
import type { Product } from '#/types/product';
import { ProductRating } from '#/components/product-rating';
import Image from 'next/image';
import { Pricing } from "#/components/pricing";
import type { Product } from "#/types/product";
import { ProductRating } from "#/components/product-rating";
import Image from "next/image";

export async function SingleProduct() {
const product: Product = await fetch(
`https://app-router-api.vercel.app/api/products?id=1`,
`https://app-router-api.vercel.app/api/products?id=1`
).then((res) => res.json());

return (
Expand All @@ -31,7 +31,7 @@ export async function SingleProduct() {
alt={product.name}
fill
sizes="(min-width: 1184px) 75px, (min-width: 768px) 8.33vw, 16.66vw"
priority
loading="lazy"
/>
</div>
<div className="relative aspect-square w-1/3">
Expand All @@ -41,7 +41,7 @@ export async function SingleProduct() {
alt={product.name}
fill
sizes="(min-width: 1184px) 75px, (min-width: 768px) 8.33vw, 16.66vw"
priority
loading="lazy"
/>
</div>
<div className="relative aspect-square w-1/3">
Expand All @@ -51,7 +51,7 @@ export async function SingleProduct() {
alt={product.name}
fill
sizes="(min-width: 1184px) 75px, (min-width: 768px) 8.33vw, 16.66vw"
priority
loading="lazy"
/>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions lib/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Times are in milliseconds
export const delayShippingEstimate = 400;
export const delayRecommendedProducts = 800;
export const delayReviews = 1000;
export const delayShippingEstimate = 200;
export const delayRecommendedProducts = 500;
export const delayReviews = 600;
Loading