Potential fix for code scanning alert no. 2: Clear-text storage of sensitive information #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/venkateshpabbati/adk-python/security/code-scanning/2
General approach:
To address the risk of clear-text storage of sensitive information, the code should never write a sensitive credential such as a Google API key directly to disk in plaintext. The best fix is to avoid writing the API key to the
.envfile at all. Instead, the code should either:GOOGLE_API_KEYenvironment variable themselves,Specific best fix:
Remove the line writing the
GOOGLE_API_KEYvalue to the.envfile in_generate_files(). Instead, inform the user that they need to set theGOOGLE_API_KEYenvironment variable manually, and add a clear message reminding them not to check secrets into version control. This ensures no sensitive data is inadvertently written to disk.File/region to change:
src/google/adk/cli/cli_create.py, lines 193–194, do not append theGOOGLE_API_KEYline to thelineslist.click.sechoinfo message to the user indicating that they need to setGOOGLE_API_KEYthemselves.Suggested fixes powered by Copilot Autofix. Review carefully before merging.