Make use of dburles:mongo-collection-instances #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2017
|
Note: I added a feature request to the files package where the FilesCollection would be references by the Mongo.Collection: veliovgroup/Meteor-Files#464 If that feature would be accepted and added, the line would not be required to be added manually. |
jankapunkt
commented
Jul 24, 2017
| } | ||
|
|
||
| this.collection = Meteor.connection._mongo_livedata_collections[this.data.atts.collection]; | ||
| console.log(this.data); |
There was a problem hiding this comment.
sry for this, removed all others but that :-/
There was a problem hiding this comment.
You can remove it by additional commit, no need to send PR, it will go to this PR
dr-dimitru
requested changes
Jul 30, 2017
| } | ||
|
|
||
| this.collection = Meteor.connection._mongo_livedata_collections[this.data.atts.collection]; | ||
| console.log(this.data); |
There was a problem hiding this comment.
You can remove it by additional commit, no need to send PR, it will go to this PR
dr-dimitru
added a commit
that referenced
this pull request
Jul 30, 2017
- Support for `dburles:mongo-collection-instances`, see #28 , thanks to @jankapunkt - `dburles:mongo-collection-instances` is possible fix for issues like #19
|
@jankapunkt thank you a lot for contribution. Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't intend to use global namespace, since all my collections are encapsulated and referenced via dburles:mongo-collection-instances.
However, I also do not like workarounds in onRendered template functions. This approach assumes the convention of linking your FilesCollection to it's underlying collection instance.
Example:
Link the FilesCollection instance to the Mongo.Collection instance:
Retrieve the FilesCollection as every other collection instance:
The change does not add a dependency to dburles:mongo-collection-instances but only checks if it's functionality (Mongo.Collection.get) exists. If not it falls back to the old mechanism.