Skip to content

Fix awgn() in channels.py #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
veeresht merged 2 commits into from
Jun 29, 2016
Merged

Fix awgn() in channels.py #10

veeresht merged 2 commits into from
Jun 29, 2016

Conversation

@hoo89
Copy link

@hoo89 hoo89 commented Jun 29, 2016

Fix #9

  • Fix comparing operator 'is' to '=='
  • Calculate abs from input signals before it is squared

@coveralls
Copy link

coveralls commented Jun 29, 2016

Coverage Status

Coverage remained the same at 54.326% when pulling e7b053a on hoo89:fix_awgn into 55f2489 on veeresht:master.

@veeresht veeresht merged commit 57f5ebd into veeresht:master Jun 29, 2016
@veeresht
Copy link
Owner

veeresht commented Jun 29, 2016

Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoo89 @coveralls @veeresht