There is no opentelemetry-instrumentation-valkey

[PabloReszczynski]

On the Opentelemetry section on the documentation, it mentions installing opentelemetry-instrumentation-valkey, but only opentelemetry-instrumentation-redis exists, which is only compatible with redis.
Was this done by mistake searching–and–replacing on the docs after the fork was done?
What do you think would be the effort on forking opentelemetry-instrumentation-redis as well?

[amirreza8002]

hi
are you sure that package doesn't work with valkey?
redis packages usually work with valkey

about the second question, i'd first open an issue or discussion in the repo
https://github.com/open-telemetry/opentelemetry-python-contrib
maybe they'd be willing to add a valkey version
if not, i don't think it'd be very hard to fork it, since it is a small package

[PabloReszczynski]

I checked the source code of the repo, and it explicitly imports the redis package. This is because the package instruments the redis library, not the connection to the protocol.

[amirreza8002]

it's probably still usable
since you can connect to valkey using redis-py
tho it's a dependency that i wouldn't add

I'd try discussing valkey support with the maintainers of that package

[mkmkme]

Hey @PabloReszczynski! Thanks for bringing this up, this is definitely a fluke caused by a mistake when the forking was performed. There's indeed no opentelemetry-instrumentation-valkey package. And thanks @amirreza8002 for volunteering to discuss this matter with opentelemetry folks!

In the meantime, I'll fix the documentation