-
Notifications
You must be signed in to change notification settings - Fork 70
Initial version of Valkey 9.0 release blog #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle J. Davis <[email protected]>
madolson
reviewed
Oct 13, 2025
Member
madolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The technical details look pretty good
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Kyle J. Davis <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Kyle J. Davis <[email protected]>
madolson
reviewed
Oct 14, 2025
Signed-off-by: Kyle J. Davis <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Kyle J. Davis <[email protected]>
madolson
approved these changes
Oct 14, 2025
Member
madolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like what is left is subjective, I think as is the blog looks fine.
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Kyle J. Davis <[email protected]>
makubo-aws
reviewed
Oct 15, 2025
Signed-off-by: Kyle J. Davis <[email protected]>
stockholmux
pushed a commit
that referenced
this pull request
Oct 23, 2025
This PR adds a banner to the top of the Valkey website announcing the release of Valkey 9.0 and linking to the release blog post (PR #390). ## Changes - Added banner configuration to `config.toml` with a concise message about Valkey 9.0 - The banner links to the blog post at `/blog/introducing-valkey-9/` - Uses the existing banner infrastructure (templates, styling, and JavaScript) already present in the website ## Banner Features - **Message**: "What's new in Valkey 9.0? Discover new features and improvements." - **Dismissible**: Users can close the banner using the X button on the right - **Persistent**: Banner dismissal is remembered in localStorage for 24 hours - **Responsive**: Works across all pages and devices, displays on a single line without wrapping ## Screenshot <img src="https://github.com/user-attachments/assets/d559710e-5e0d-44af-847f-7f9128b5f881"> The banner appears at the top of every page with white text on a purple background (#2D2471), consistent with the existing banner design system. ## Implementation Note This implementation leverages the complete banner system that was already built into the website templates. No template, styling, or JavaScript changes were needed - only the configuration value was added to enable the banner. Fixes #398 <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Add a new banner for a what's new for Valkey 9.0</issue_title> > <issue_description>Add a banner to the top of the Valkey website that includes what's a link to the new unpublished blog post #390. </issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> Fixes #398 <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/valkey-io/valkey-io.github.io/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: madolson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial version of the blog for the 9.0 release.
I ran into a few issues that I could use some help with:
Issues Resolved
#312
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.