Skip to content

Conversation

@phiro56
Copy link
Contributor

@phiro56 phiro56 commented Aug 24, 2025

feat: add topics sidebar and breadcrumbs navigation

  • Add topics list page and sidebar navigation
  • Implement search functionality for topics in sidebar
  • Add breadcrumbs navigation
Screenshot 2025-08-24 at 5 40 39 PM

- Add topics list page and sidebar navigation
- Implement search functionality for topics in sidebar
- Add breadcrumbs navigation

Signed-off-by: Daniel Phillips <[email protected]>
@phiro56 phiro56 force-pushed the refactor/topics-page-sidebar-breadcrumbs branch from d5d9746 to 390fdf4 Compare October 8, 2025 20:08
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like revised the look and the bread crumbs in this PR however the search functionality isn't probably what people expect. This functionality is searching the left hand column of the page only not the contents of the page. I think people will expect that this search box searches the contents of the pages too. Also the search functionality is missing on /topics/ but not on sub pages of /topics/.

Maybe we can split these two features apart? The breadcrumbs and new look/feel would able to be merged quickly.

@phiro56
Copy link
Contributor Author

phiro56 commented Oct 27, 2025

Hey @stockholmux....
Removed search form topics side bar.
Current PR should only include new breadcrumbs and topic pages template..
Screenshot 2025-10-27 at 9 28 48 AM

@stockholmux
Copy link
Member

@phiro56 The screenshot looks right but look like this PR still has the search bar? Am i missing something?

https://github.com/valkey-io/valkey-io.github.io/pull/340/files#diff-08d25fe35cd8b02ffb2456541758a0862dfdeda5411d19c889687df2240541f3R61

@phiro56
Copy link
Contributor Author

phiro56 commented Oct 27, 2025

@stockholmux I failed to push earlier... Should be good now...

Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stockholmux stockholmux merged commit fc901e0 into valkey-io:main Oct 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants