feat: redesign footer with social media icons and links #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add social media icons and links to the footer, including Slack, GitHub, LinkedIn, X (Twitter), and Connect. Improve footer layout and styling. Signed-off-by: Daniel Phillips <[email protected]>
madolson
reviewed
Apr 24, 2025
Member
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
Assuming the css is correct because it looks nice on the rendered page, minor comments
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Daniel Phillips <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Daniel Phillips <[email protected]>
Signed-off-by: Daniel Phillips <[email protected]>
madolson
approved these changes
Apr 28, 2025
zarkash-aws
pushed a commit
to zarkash-aws/valkey-io.github.io
that referenced
this pull request
Jun 12, 2025
Feat: redesign footer with social media icons and links. Add social media icons and links to the footer, including Slack, GitHub, LinkedIn, X (Twitter), and Connect. Improve footer layout and styling. <img width="1727" alt="Screenshot 2025-04-17 at 1 58 53 PM" src="https://github.com/user-attachments/assets/5f311820-ac2e-460c-8ddd-93fe77e7a81d" /> <img width="514" alt="Screenshot 2025-04-17 at 1 59 03 PM" src="https://github.com/user-attachments/assets/5de67d56-9b69-4810-b615-4af75d9487e6" /> --------- Signed-off-by: Daniel Phillips <[email protected]> Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Shai Zarka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: redesign footer with social media icons and links. Add social media icons and links to the footer, including Slack, GitHub, LinkedIn, X (Twitter), and Connect. Improve footer layout and styling.