Skip to content

Conversation

@Nikhil-Manglore
Copy link
Member

@Nikhil-Manglore Nikhil-Manglore commented Mar 29, 2025

Description

This PR will add the JSON commands on the Valkey website. Note that this PR was created off of a branch of the bloom filter documentation PR. Merge conflicts will occur if that PR needs to be changed so I will update accordingly.

Example:

Screenshot 2025-04-02 at 5 10 01 PM

Check List

  • [ X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@Nikhil-Manglore Nikhil-Manglore changed the title Json documentation Adding JSON Documentation Mar 29, 2025
@Nikhil-Manglore Nikhil-Manglore changed the title Adding JSON Documentation Adding functionality for the JSON module to have commands displayed on the Valkey Website Mar 29, 2025
Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madolson madolson merged commit a5d94b2 into valkey-io:main Apr 29, 2025
1 check passed
@Nikhil-Manglore Nikhil-Manglore deleted the json_documentation branch April 29, 2025 21:45
zarkash-aws pushed a commit to zarkash-aws/valkey-io.github.io that referenced this pull request Jun 12, 2025
…n the Valkey Website (valkey-io#230)

### Description

This PR will add the JSON commands on the Valkey website. Note that this
PR was created off of a branch of the [bloom filter documentation
PR](valkey-io#212). Merge
conflicts will occur if that PR needs to be changed so I will update
accordingly.

Example:

<img width="958" alt="Screenshot 2025-04-02 at 5 10 01 PM"
src="https://github.com/user-attachments/assets/0e4e7b6f-6a82-4757-a70f-e320dc9cae00"
/>

### Check List
- [ X] Commits are signed per the DCO using `--signoff`

By submitting this pull request, I confirm that my contribution is made
under the terms of the BSD-3-Clause License.

---------

Signed-off-by: zackcam <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
Co-authored-by: zackcam <[email protected]>
Signed-off-by: Shai Zarka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants