Add a deploy dispatch event #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
zuiderkwast
approved these changes
Feb 27, 2025
madolson
added a commit
to valkey-io/valkey-doc
that referenced
this pull request
Feb 27, 2025
…239) This will allow the website to automatically get updated when we update the doc repository. I setup a repository action on the website github, which allows incoming events to trigger the build and deploy action. Some notes about security. The credential being used has write permission the website repository, so to compensate I locked down all the branches to require PRs, which should prevent any malicious attackers if they get access to the credentials. The downside is no more directly pushing to the website, which I think is an OK tradeoff. This PR is dependent on this PR getting merged first: valkey-io/valkey-io.github.io#214. Some other things I investigated: 1. [Re-usable workflows](https://docs.github.com/en/actions/sharing-automations/reusing-workflows): I wasn't able to get the deploy functionality to have permissions across repository, these seem to only work correctly within the same repository. 2. Triggering the website build from this repo. This required duplicating the build and deploy steps. This seemed like a cleaner approach. Signed-off-by: Madelyn Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows someone with sufficient permissions to deploy the website by issuing a dispatch event to this repository. This is needed to allow other repository pushes to update the website.
Issues Resolved
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.