Skip to content

Conversation

@Marcholio
Copy link
Contributor

Added support for Finnish license plate validation. Valid examples from traficom site:

  • TRA-100, JCK-33 - normal car
  • QUU-1 - special plate available on special request
  • 10-TRF, BX-971 - motorcycle
  • MA-126 - museum car
  • 100-EAI - tractor or other work equipment
  • 199-AA - Snowmobile
  • C-11012, CD-1124 - Diplomat car

Basically all options can be written with dash, with space or all together.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1790 (c4ac9a6) into master (13651ea) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1790   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2030    +1     
  Branches       457       457           
=========================================
+ Hits          2029      2030    +1     
Impacted Files Coverage Δ
src/lib/isLicensePlate.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...c4ac9a6. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 ! Thank you for your PR @Marcholio

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Oct 25, 2021
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contrib! 🎉

@profnandaa profnandaa merged commit 526417a into validatorjs:master Oct 30, 2021
@Marcholio Marcholio deleted the feature/finnish-license-plates branch October 30, 2021 07:18
theteladras pushed a commit to theteladras/validator.js that referenced this pull request Oct 30, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants