feat(isMobilePhone) Fix Mobile Phone Regex Pakistan(PK) #1778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the regex to validate mobile numbers correctly for Pakistan
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2029
Branches 457 457
=========================================
Hits 2029 2029
Continue to review full report at Codecov.
|
tux-tn
requested changes
Oct 19, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Thank you for your PR @hammad20120 looks like your regex is also validating landline numbers. Please check and address my comment below!
Update pakistan mobile regex according to suggestion Co-authored-by: Sarhan Aissi <[email protected]>
tux-tn
approved these changes
Oct 19, 2021
Member
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Thank you for making the necessary changes! LGTM 🎉
tux-tn
added
hacktoberfest-accepted
ready-to-land
profnandaa
approved these changes
Oct 30, 2021
Member
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contrib! 🎉
theteladras
pushed a commit
to theteladras/validator.js
that referenced
this pull request
Oct 30, 2021
* Fix Mobile Phone Regex Pakistan(PK) Update the regex to validate mobile numbers correctly for Pakistan * Add tests for mobile number validation locale en-PK (Pakistan) * Linting fix * Update src/lib/isMobilePhone.js Update pakistan mobile regex according to suggestion Co-authored-by: Sarhan Aissi <[email protected]> * Update tests for PK phone numbers Co-authored-by: Sarhan Aissi <[email protected]>
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
* Fix Mobile Phone Regex Pakistan(PK) Update the regex to validate mobile numbers correctly for Pakistan * Add tests for mobile number validation locale en-PK (Pakistan) * Linting fix * Update src/lib/isMobilePhone.js Update pakistan mobile regex according to suggestion Co-authored-by: Sarhan Aissi <[email protected]> * Update tests for PK phone numbers Co-authored-by: Sarhan Aissi <[email protected]>
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
* Fix Mobile Phone Regex Pakistan(PK) Update the regex to validate mobile numbers correctly for Pakistan * Add tests for mobile number validation locale en-PK (Pakistan) * Linting fix * Update src/lib/isMobilePhone.js Update pakistan mobile regex according to suggestion Co-authored-by: Sarhan Aissi <[email protected]> * Update tests for PK phone numbers Co-authored-by: Sarhan Aissi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the mobile phone regex for Pakistan.
Reference: 1, 2
Added tests for mobile phone, local en-PK (Pakistan)
Checklist