fix: apply details background only when details is an overlay #10303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For 24.8 and 24.9, #9669 changed the MDL base styles so that a background color is applied to the details even if the details are not shown as an overlay. That seems like a mistake as the v25 base styles only apply a background when the details are shown as an overlay:
web-components/packages/master-detail-layout/src/styles/vaadin-master-detail-layout-base-styles.js
Lines 146 to 149 in 5a13239
This moves the background color to the more specific rule that only applies when rendering details as an overlay.
Fixes #10299
Type of change