Skip to content

Conversation

sissbruecker
Copy link
Contributor

Description

For 24.8 and 24.9, #9669 changed the MDL base styles so that a background color is applied to the details even if the details are not shown as an overlay. That seems like a mistake as the v25 base styles only apply a background when the details are shown as an overlay:

:host(:is([drawer], [stack])) [part='detail'] {
background: var(--vaadin-master-detail-layout-detail-background, var(--vaadin-background-color));
box-shadow: var(--vaadin-master-detail-layout-detail-shadow, 0 0 20px 0 rgba(0, 0, 0, 0.3));
}

This moves the background color to the more specific rule that only applies when rendering details as an overlay.

Fixes #10299

Type of change

  • Bugfix

Copy link

sonarqubecloud bot commented Oct 9, 2025

Copy link
Member

@jouni jouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason for moving the background color was that even in split mode, the master and detail parts can cross-fade, and the detail part shows on top of the initial master view briefly. But perhaps that’s a concern themes should worry about, not the base styles.

@sissbruecker
Copy link
Contributor Author

We can revert this and update themes to use the base background color on non-overlay details as well if this turns out to be an issue.

@sissbruecker sissbruecker merged commit 853e8e3 into 24.9 Oct 10, 2025
9 checks passed
@sissbruecker sissbruecker deleted the fix/mdl-base-styles-background-scope branch October 10, 2025 07:37
sissbruecker added a commit that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants