Skip to content

Conversation

@JJuszczyk
Copy link

No description provided.

@JJuszczyk JJuszczyk requested a review from shieldo February 19, 2020 10:29
Copy link

@shieldo shieldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shieldo
Copy link

shieldo commented Feb 19, 2020

However, we might want to keep this branch, and not merge it to master

Also this branch should be based on allow_symfony_3, not master

@JJuszczyk JJuszczyk changed the base branch from master to allow_symfony_3 February 19, 2020 10:55
@JJuszczyk
Copy link
Author

Yea, I'm aware of that, also changed the branch base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants