fix: chrome support + manifest browser based split #409
+96
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocerquone
commented
Jul 20, 2025
| @@ -12,8 +12,7 @@ | |||
| "512": "/assets/icon-512.png" | |||
| }, | |||
| "background": { | |||
| "scripts": ["background.js"], | |||
| "persistent": false | |||
There was a problem hiding this comment.
i'm not sure if this is to be readded for firefox
|
hello there @kitten are you maintaining this package or know someone who is able to review this? |
|
It would be lovely if someone could merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there.
Following #408, and noticing how even building the extension from source, it wasn't getting picked up by chrome because the support for v2 manifests is expired, I worked to upgrade it.
In doing so, I've noticed how there are a few properties required by chrome but not supported by firefox.
Hence I decided to split the two manifests.
dist/extensionindist/extension/chrome../firefoxchrome-extension.zipandfirefox-extension.zippageActiontoaction. In doing so, I minimized the changes as much as possible to the lockfile to be able to merge this pr confidently.Screencast on chrome
Screen.Recording.2025-07-21.at.00.53.50.mov