Implement BlockData.Type interfaces, part 1 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusicScore
force-pushed
the
blockdata-type-pt1
branch
from
613161a to
00f3de5
Compare
Author
|
Force-pushed to fix incompatibilities, additionally cleaned up some minor meta mistakes and errors. Tested on Paper 1.13.2 and 1.14.4. |
Covers everything from bamboo leaves to end portal frame eyes
Removed instances of the "is_" prefix. Those are mostly unnecessary Made some of the meta documentation clearer, and capitalized "Eye of Ender"
Disable direct property output for cake materials (e.g. m@cake[level=0] will not be seen). Determining the bites a cake has left is not in the scope of the MaterialLevel property Add additional meta to clarify that we have a dedicated property for cake bites Allow both "max_" and "maximum_" prefixes Disable property output for when the level is 0. The level being 0 is a trivial case
Fix the MaterialBedSide property not registering Correct the property output for MaterialBrewingStandBottles, and allow single-item inputs for MaterialTag.bottles mechanism Fix MaterialBambooLeaves property registering twice
MusicScore
force-pushed
the
blockdata-type-pt1
branch
from
00f3de5 to
d27927a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers everything from bamboo leaves to end portal frame eyes
Addresses #2