Skip to content

⬆️ react 16 / use of jest #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 30, 2017
Merged

⬆️ react 16 / use of jest #77

merged 12 commits into from
Oct 30, 2017

Conversation

fabienjuif
Copy link
Member

@fabienjuif fabienjuif commented Oct 27, 2017 •
edited
Loading

fixes #76

  • Rewrite test (using jest)
  • Integrations tests (react 16, react 15)
    • React 16
    • React 15 (no reason it didn't work since code is not changed -only tests are-)

@coveralls
Copy link

Coverage Status

Coverage decreased (-20.8%) to 79.221% when pulling c843bbe on react-16 into cd438d9 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.4%) to 89.61% when pulling 2f0611e on react-16 into cd438d9 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.4%) to 89.61% when pulling c7071e7 on react-16 into cd438d9 on master.

@fabienjuif fabienjuif changed the title 🚧 react 16 ⬆️ react 16 Oct 27, 2017
@fabienjuif
Copy link
Member Author

fabienjuif commented Oct 27, 2017 •
edited by frinyvonnick
Loading

@Taranys What about promise implementation (#26) ?
I think this is not working right now ? Can I delete it ?

@fabienjuif fabienjuif changed the title ⬆️ react 16 ⬆️ react 16 / use of jest Oct 27, 2017
@fabienjuif
Copy link
Member Author

@Taranys @frinyvonnick ping

@Taranys
Copy link
Collaborator

Taranys commented Oct 30, 2017

Yes go ahead. Delete it !!

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 98.462% when pulling c297a23 on react-16 into cd438d9 on master.

@fabienjuif fabienjuif mentioned this pull request Oct 30, 2017
Closed
@fabienjuif fabienjuif requested a review from bpetetot October 30, 2017 13:28
bpetetot
bpetetot requested changes Oct 30, 2017
View reviewed changes
package.json Outdated
"peerDependencies": {
"prop-types": "^15.5.8",
"react": "^15.3.0",
"react": "^15.3.0 || ^16.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set peerDependencies : "^15.x.x || ^16.x.x"

can be apply to : prop-types and tinycolor2

package.json
"react-addons-test-utils": "^15.4.2",
"react-dom": "^15.3.0",
"react-test-renderer": "^15.5.4",
"prop-types": "^15.6.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the same version in the peerDependency : 15.5.8

bpetetot
bpetetot approved these changes Oct 30, 2017
View reviewed changes
Copy link
Collaborator

@bpetetot bpetetot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 98.462% when pulling 2301d54 on react-16 into cd438d9 on master.

@fabienjuif fabienjuif merged commit b3f2b3a into master Oct 30, 2017
@fabienjuif fabienjuif deleted the react-16 branch October 30, 2017 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpetetot bpetetot bpetetot approved these changes

@Taranys Taranys Awaiting requested review from Taranys

@ptitFicus ptitFicus Awaiting requested review from ptitFicus

@frinyvonnick frinyvonnick Awaiting requested review from frinyvonnick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning after witch to react 16
4 participants
@fabienjuif @coveralls @Taranys @bpetetot