Feat #18 - wait parameter is boosted - code coverage #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienjuif
changed the title
src/index.jsx
Outdated
| return Boolean(wait) | ||
| } | ||
|
|
||
| isLoadAFunction = () => { |
added 2 commits
September 25, 2016 21:39
src/index.spec.js
Outdated
| it('should call the `load` function parameter if present', () => { | ||
| // Mount | ||
| const load = spy(() => {}) | ||
| const load2 = spy(() => {}) |
There was a problem hiding this comment.
Maybe a more explicit naming ?
|
@Zenika/nantes review plz plz |
frinyvonnick
requested changes
Oct 5, 2016
| // Implicitly meaning that this is an array of props | ||
| if (Array.isArray(wait)) { | ||
| return wait | ||
| .map(w => Boolean(this.props[w])) |
There was a problem hiding this comment.
Use better naming convention for variables
src/index.spec.js
Outdated
| // Load function is not called twice | ||
| // Graphic component is called | ||
| // Loader shouldn't be printed | ||
| load.should.have.been.called.once() |
There was a problem hiding this comment.
You don't have to call twice the line called.once(). Parenthesis are unnecessary
src/index.spec.js
Outdated
| // Load function is called | ||
| // Graphic component isn't printed | ||
| // Loader should be Dots | ||
| load.should.have.been.called.once() |
There was a problem hiding this comment.
The load.should.have.been.called.once() is unnecessary because load.should.have.been.called.twice() already test this.
frinyvonnick
approved these changes
Oct 5, 2016
frinyvonnick
requested changes
Oct 5, 2016
src/index.spec.js
Outdated
| // Load function is not called twice | ||
| // Graphic component is called | ||
| // Loader shouldn't be printed | ||
| load.should.have.been.called.once |
There was a problem hiding this comment.
You could use a function to avoid repetition
fabienjuif
commented
Oct 5, 2016
src/index.spec.js
Outdated
| expect(loaded.find(Dots).node).to.be.undefined | ||
| } | ||
|
|
||
| const isLoaded = (load, loaded, CustomLoader = undefined) => { |
There was a problem hiding this comment.
Delete = undefined
or = Dots
fabienjuif
commented
Oct 5, 2016
src/index.spec.js
Outdated
| // Change `loaded` value | ||
| loaded.setProps({ loaded: true }) | ||
|
|
||
| // Load function is not called twice |
There was a problem hiding this comment.
Move commentaries with functions
frinyvonnick
approved these changes
Oct 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.