Skip to content

Conversation

@ctrl-space
Copy link

First incomplete iteration of adding urlpathvariables to FitNesseRunner.
Feedback welcome.

Thanks,
Claes

@amolenaar
Copy link
Collaborator

Hi, I think this is starting to look quite okay. You might want to use a value array, instead of concatenating all properties with `&'. Then the format is closer to Java.

Something like this:

@FitNesseRunner.UrlPathVariables({ "ID=100", "gizmo=true"})

You might want to figure out to what extend the current parser logic (e.g. the Request class) can be used. Some change might be required, but it will keep the code DRY.

(and the variables need to be used somewhere, of course)

@ctrl-space
Copy link
Author

Updated annotation and using Request to parse query string. Added urlpathvariables to context.

@ctrl-space ctrl-space closed this Oct 17, 2016
@ctrl-space ctrl-space reopened this Oct 17, 2016
@six42 six42 mentioned this pull request Sep 23, 2018
@ctrl-space ctrl-space closed this by deleting the head repository Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants