Add juno filter #245
Open
Add juno filter #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates? Would love to get this in! |
una
reviewed
Nov 2, 2016
source/scss/juno.scss
Outdated
| filter: contrast(1.25) brightness(.989) saturate(1.1) grayscale(.19) $filters; | ||
|
|
||
| &::after { | ||
| background: radial-gradient(circle, rgba(150, 160, 150, .4) 100%, rgb(192, 110, 201)); |
There was a problem hiding this comment.
This PR looks awesome!! The only change I would make is changing this first value in the gradient from rgba(150, 160, 150, .4) to rgba(150, 160, 150, .8) -- try that and let me know what you think.
source/scss/juno.scss
Outdated
| // } | ||
| @mixin juno($filters...) { | ||
| @include filter-base; | ||
| filter: contrast(1.25) brightness(.989) saturate(1.1) grayscale(.19) $filters; |
There was a problem hiding this comment.
Maybe just remove brightness, since .989 isn't going to be making much of a difference here
|
Sorry for the delay. I've been really busy lately, but your suggestion is great. I just made the adjustment. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.