chore: bump unrs-resolver to v1.9.0
#382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d6d463 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis change updates several dependencies and devDependencies in the Changes
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR bumps several dependency versions, including unrs-resolver to v1.9.0, to keep the project up to date.
- Updated unrs-resolver from 1.7.10 to 1.9.0
- Bumped various @typescript-eslint, @swc/core, and jest versions
- Other minor version bumps to support maintenance and consistency
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (21)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on macos-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8 on macos-latest
- GitHub Check: autofix
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (actions)
- GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
🔇 Additional comments (6)
package.json (6)
88-88: Confirm PR scope and verify unrs-resolver bump
The PR description only mentions bumpingunrs-resolver, yet multiple other dependencies are updated here. Please confirm this expanded scope and review the changelog for[email protected]for any breaking changes.
113-113: Verify @swc/core 1.12.0 upgrade
Ensure compatibility with your build tooling and@swc-node/jestsetup, and run the test suite to catch any regressions.
124-124: Approve bump of @types/node to 22.15.31
This is a patch-level update. Safe to proceed.
136-136: Approve bump of eslint-import-resolver-typescript to 4.4.3
No breaking changes in this minor version.
141-141: Approve bump of jest and eslint-plugin-jest
Upgrading to Jest 30.0.0 and plugin 28.13.3. Ensure the test suite runs under the new versions.Also applies to: 152-152
156-156: Approve bump of path-serializer to 0.5.0
Minor version bump. Looks good.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 6621925 in 1 minute and 54 seconds. Click for details.
- Reviewed
86lines of code in1files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:88
- Draft comment:
Verify that updating 'unrs-resolver' to '^1.9.0' indeed fixes the macOS Docker native binding error (issue #337). - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to verify that a dependency update fixes a specific issue. It violates the rule against asking the author to confirm or verify things.
2. package.json:171
- Draft comment:
Align the resolution for '@typescript-eslint/utils': the dependency is bumped to ^8.34.0 but the resolution still enforces ^8.33.1. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. package.json:152
- Draft comment:
Ensure the upgrade from jest beta (^30.0.0-beta.9) to the stable release (^30.0.0) does not introduce test regressions. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to ensure that the upgrade does not introduce test regressions, which is a form of asking them to double-check their work. This violates the rule against asking the author to ensure behavior is intended or tested.
Workflow ID: wflow_ezZAe1g79IMVSUCH
You can customize 
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 94 94
Lines 4907 4907
Branches 1844 1822 -22
=======================================
Hits 4712 4712
Misses 194 194
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 9a220dc in 2 minutes and 20 seconds. Click for details.
- Reviewed
86lines of code in1files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:85
- Draft comment:
Confirm that unrs-resolver v1.9.0 indeed fixes the native binding error (#337). - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to confirm a specific fix related to a dependency version. It violates the rule against asking the author to confirm their intention or to ensure behavior is intended. It doesn't provide a specific code suggestion or ask for a test to be written.
2. package.json:170
- Draft comment:
Consider updating the resolution for '@typescript-eslint/utils' to match the bumped dependency version. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =40%<= threshold50%The comment suggests updating the resolution for a specific dependency to match a version change. This is a specific suggestion related to dependency management, which is generally not allowed unless it's about confirming intentionality or best practices. However, it doesn't ask for confirmation or suggest a best practice, so it seems to be a straightforward suggestion to align versions.
3. package.json:149
- Draft comment:
Verify that upgrading jest from a beta version to a stable version (^30.0.0) doesn’t introduce compatibility issues. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_oeBQkBjpq2qfEXZ7
You can customize
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 805e51f in 1 minute and 47 seconds. Click for details.
- Reviewed
91lines of code in1files - Skipped
1files when reviewing. - Skipped posting
9draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:88
- Draft comment:
Bump 'unrs-resolver' to ^1.9.0 as intended for #337. Confirm this version fixes the Docker macOS native binding issue. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. package.json:80
- Draft comment:
Update TypeScript‐ESLint packages to ^8.34.0 for consistency across dependencies. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. package.json:113
- Draft comment:
Bump '@swc/core' to ^1.12.0; this minor update appears appropriate. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. package.json:136
- Draft comment:
Upgrade 'eslint-import-resolver-typescript' to ^4.4.3. This minor bump seems safe. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. package.json:141
- Draft comment:
Update 'eslint-plugin-jest' to ^28.13.3. Ensure compatibility with the latest Jest. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. package.json:152
- Draft comment:
Bump 'jest' to ^30.0.0 (from a beta release) – verify that test suites pass with this stable version. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
7. package.json:156
- Draft comment:
Upgrade 'path-serializer' to ^0.5.0; this minor version bump looks appropriate. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
8. package.json:167
- Draft comment:
Bump 'typescript-eslint' to ^8.34.0 in devDependencies to align with related packages. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
9. package.json:171
- Draft comment:
Update resolution for '@typescript-eslint/utils' to ^8.34.0 so it matches dependency versions. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_XtrZCvz8CZxc6fiw
You can customize
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed b60ee4e in 2 minutes and 26 seconds. Click for details.
- Reviewed
111lines of code in2files - Skipped
1files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .changeset/silly-roses-repeat.md:5
- Draft comment:
Consider replacing the contraction "it'll" with "it will" for clarity in the changeset message. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. package.json:88
- Draft comment:
Bump unrs-resolver to v1.9.0 looks correct. Please ensure the fallback to the 'napi-postinstall' check is validated in your tests. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. package.json:152
- Draft comment:
The jest dependency was updated from a beta version to a stable release (^30.0.0). Confirm that this update does not introduce any breaking changes in your test suite. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. .changeset/silly-roses-repeat.md:5
- Draft comment:
Typographical suggestion: consider changing "it'll fallback" to "it will fall back" (or "it'll fall back") for clarity and grammatical correctness. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a very minor grammatical correction. While technically correct (fallback is a noun, fall back is a verb), this level of nitpicking on a changelog entry doesn't add meaningful value. Changelogs are informal documentation and both forms are commonly used and understood. This doesn't impact code quality or functionality. The grammatical correction is technically accurate. Poor grammar in documentation could be seen as unprofessional. While technically correct, this level of grammatical nitpicking on an informal changelog entry creates noise without adding meaningful value. The current form is perfectly understandable. Delete this comment as it's an overly pedantic grammatical suggestion on an informal documentation that doesn't impact code quality or understanding.
Workflow ID: wflow_Qjmhjo5vu8I4u55p
You can customize
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 2d6d463 in 1 minute and 48 seconds. Click for details.
- Reviewed
128lines of code in3files - Skipped
1files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .changeset/silly-roses-repeat.md:5
- Draft comment:
Consider rephrasing "it'll fallback" to "falls back" for clarity. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. package.json:88
- Draft comment:
Bumping unrs-resolver to ^1.9.0 should address the native binding issue in Docker. Confirm compatibility. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is about a dependency change and asks to confirm compatibility, which violates the rules against commenting on dependency changes and asking for confirmation.
3. package.json:97
- Draft comment:
Upgrade of @angular-eslint/template-parser to ^20.0.0 may be breaking; ensure configuration compatibility. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about a dependency upgrade and suggests ensuring configuration compatibility. It violates the rule against commenting on dependency changes and asking the author to ensure compatibility.
4. package.json:149
- Draft comment:
Upgrading Jest from a beta to a stable release (^30.0.0) is good; verify that all tests pass. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to verify that all tests pass after upgrading a dependency, which is not allowed according to the rules. It doesn't provide a specific suggestion or point out a specific issue with the code.
5. test/fixtures/component.html:127
- Draft comment:
Replacing '@' with '@' ensures proper HTML rendering; maintain consistency in code snippets. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining why a change was made. It doesn't suggest any code improvements or ask for specific confirmations about the code's behavior.
Workflow ID: wflow_7wAKL3ilF2rwUN1W
You can customize
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/silly-roses-repeat.md (1)
5-5: Fix verb form in changeset description
Use “fall back” instead of “fallback” when used as a verb.🧰 Tools
🪛 LanguageTool
[grammar] ~5-~5: The word “fallback” is a noun. The verb is spelled with a space.
Context: ...bumpunrs-resolvertov1.9.0, it'll fallback tonapi-postinstallcheck at runtime ...(NOUN_VERB_CONFUSION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
.changeset/silly-roses-repeat.md(1 hunks)package.json(6 hunks)test/fixtures/component.html(1 hunks)
🧰 Additional context used
🪛 LanguageTool
.changeset/silly-roses-repeat.md
[grammar] ~5-~5: The word “fallback” is a noun. The verb is spelled with a space.
Context: ...bump unrs-resolver to v1.9.0, it'll fallback to napi-postinstall check at runtime ...
(NOUN_VERB_CONFUSION)
⏰ Context from checks skipped due to timeout of 90000ms (155)
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js lts/* and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8.56 on windows-latest
🔇 Additional comments (13)
test/fixtures/component.html (2)
127-127: Confirm HTML entity encoding
Escaping “@” as@properly ensures the schematics commands render correctly in HTML.
130-130: Consistent entity usage
The second Angular generate command is also correctly encoded.package.json (11)
80-80: Approve dependency bumps
Updating dependencies@typescript-eslint/typesto^8.34.0andunrs-resolverto^1.9.0aligns with the PR goals.Also applies to: 88-88
97-97: Validate major version upgrade
Bumping@angular-eslint/template-parserfrom19.xto20.0.0is a major release—ensure compatibility with your Angular version.
113-113: Approve SWC core update
The minor bump of@swc/coreto^1.12.0is backward-compatible.
124-124: Approve Node types
Updating@types/nodeto^22.15.31matches the supported Node engine range (>=21.1.0).
127-130: Approve TypeScript ESLint packages
All@typescript-eslint/*packages are now consistently at^8.34.0.
136-136: Approve resolver bump
Upgradingeslint-import-resolver-typescriptto^4.4.3is a patch-level change.
141-141: Approve Jest plugin
eslint-plugin-jestat^28.13.3is compatible with the upgradedjest@^30.0.0.
152-152: Approve Jest stable release
Switching from beta to stablejest@^30.0.0is correct.
156-156: Approve path-serializer bump
Updatingpath-serializerto^0.5.0is safe.
171-173: Resolutions updated correctly
@typescript-eslint/utilspin now matches the bumped version.
167-167:⚠️ Potential issueRemove invalid devDependency
The package"typescript-eslint"does not exist on npm. This appears to be a typo and should be removed.⛔ Skipped due to learnings
Learnt from: JounQin PR: un-ts/eslint-plugin-import-x#357 File: package.json:160-160 Timestamp: 2025-05-30T15:39:53.248Z Learning: The `typescript-eslint` package (without the `@typescript-eslint/` namespace) is the official unified entry package for ESLint flat config, not an incorrect package name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it'll fallback to
napi-postinstallcheck at runtimeclose #337
Important
Bump
unrs-resolvertov1.9.0and update several dependencies inpackage.json, with minor HTML changes incomponent.html.unrs-resolvertov1.9.0inpackage.json.@typescript-eslint/types,@angular-eslint/template-parser,@swc/core,@types/node,@typescript-eslint/eslint-plugin,@typescript-eslint/parser,@typescript-eslint/rule-tester,@typescript-eslint/utils,eslint-import-resolver-typescript,eslint-plugin-jest,jest, andpath-serializerto their latest versions inpackage.json.component.html.This description was created by
for 2d6d463. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit