Skip to content

Remove border of uui-input-lock when slotted to uui-input #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2023
Merged

Remove border of uui-input-lock when slotted to uui-input #692

merged 2 commits into from
Dec 14, 2023

Conversation

@loivsen
Copy link
Contributor

@loivsen loivsen commented Dec 13, 2023 •
edited
Loading

Description

Changes the border of uui-input-lock when slotted to uui-input.
Example before
image
Example after
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@loivsen loivsen requested a review from nielslyngsoe December 13, 2023 13:02
@github-actions
Copy link

github-actions bot commented Dec 13, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-692.westeurope.azurestaticapps.net

nielslyngsoe
nielslyngsoe approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, very good.

@github-actions
Copy link

github-actions bot commented Dec 13, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-692.westeurope.azurestaticapps.net

@loivsen loivsen merged commit 5f883be into v1/contrib Dec 14, 2023
@loivsen loivsen deleted the feature/input-lock-border-inside-input branch December 14, 2023 08:20
@iOvergaard iOvergaard added the enhancement New feature or request label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@loivsen @nielslyngsoe @iOvergaard