Skip to content

Feature/use popover container #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 29, 2023
Merged

Feature/use popover container #674

merged 17 commits into from
Nov 29, 2023

Conversation

@JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Nov 29, 2023

Replaces all remaining instances of the old uui-popover component with the new uui-popover-container

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions
Copy link

github-actions bot commented Nov 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-674.westeurope.azurestaticapps.net

@JesmoDev JesmoDev marked this pull request as ready for review November 29, 2023 04:20
nielslyngsoe
nielslyngsoe reviewed Nov 29, 2023
View reviewed changes
nielslyngsoe
nielslyngsoe reviewed Nov 29, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-674.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-674.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-674.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-674.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-674.westeurope.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 29, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-674.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 29, 2023 12:04
nielslyngsoe
nielslyngsoe approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well :-)

@nielslyngsoe nielslyngsoe merged commit c18d5c4 into v1/contrib Nov 29, 2023
@nielslyngsoe nielslyngsoe deleted the feature/use-popover-container branch November 29, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JesmoDev @nielslyngsoe