Skip to content

V16 Updated test helper for fixing the failing tests in 16.0.0-rc2 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andr317c merged 2 commits into from
May 13, 2025
Merged

V16 Updated test helper for fixing the failing tests in 16.0.0-rc2 #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
865b960
Updated ui helper due to UI changes
nhudinh0309 May 13, 2025
a199e89
Bumped version
nhudinh0309 May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/helpers/DocumentBlueprintUiHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class DocumentBlueprintUiHelper extends UiBaseLocators{
async goToDocumentBlueprint(blueprintName: string) {
await this.goToSection(ConstantHelper.sections.settings);
await this.reloadDocumentBlueprintsTree();
await this.page.getByLabel(blueprintName).click();
await this.page.getByLabel(blueprintName, {exact: true}).click();
}

async isDocumentBlueprintRootTreeItemVisible(blueprintName: string, isVisible: boolean = true, toReload: boolean = true){
Expand Down
2 changes: 1 addition & 1 deletion lib/helpers/DocumentTypeUiHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class DocumentTypeUiHelper extends UiBaseLocators {
this.createDocumentTypeWithTemplateBtn = page.locator('umb-ref-item').getByText('Document Type with Template', {exact: true});
this.createElementTypeBtn = page.locator('umb-ref-item').getByText('Element Type', {exact: true});
this.createDocumentFolderBtn = page.locator('umb-ref-item').getByText('Folder', {exact: true});
this.preventCleanupBtn = page.getByText('Prevent cleanup');
this.preventCleanupBtn = page.getByText('Prevent clean up');
this.setAsDefaultBtn = page.getByText('Set as default');
this.documentTypesMenu = page.locator('#menu-item').getByRole('link', {name: 'Document Types'});
}
Expand Down
4 changes: 2 additions & 2 deletions lib/helpers/MediaUiHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export class MediaUiHelper extends UiBaseLocators {

async deleteMediaItem(name: string) {
await this.clickActionsMenuForName(name);
await this.clickDeleteButton();
await this.clickDeleteActionMenuOption();
await this.clickConfirmToDeleteButton();
}

Expand Down Expand Up @@ -170,7 +170,7 @@ export class MediaUiHelper extends UiBaseLocators {
await this.mediaHeader.click();
await expect(this.mediaHeaderActionsMenu).toBeVisible();
await this.mediaHeaderActionsMenu.click()
await this.clickReloadChildrenButton();
await this.clickReloadChildrenActionMenuOption();
}

async isMediaTreeItemVisible(name: string, isVisible: boolean = true) {
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@umbraco/playwright-testhelpers",
"version": "16.0.13",
"version": "16.0.14",
"description": "Test helpers for making playwright tests for Umbraco solutions",
"main": "dist/lib/index.js",
"files": [
Expand Down