Document input: Find variant name #20853
Merged
+26
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where document inputs were displaying the wrong variant name by implementing variant-aware name resolution using the UmbDocumentItemDataResolver.
Key Changes:
- Introduced a protected
_requestItemName()method inUmbPickerInputContextthat can be overridden by subclasses to customize how item names are resolved - Overrode this method in
UmbDocumentPickerInputContextto useUmbDocumentItemDataResolverfor variant-aware name resolution - Added helper methods
getSelectedItems()andgetSelectedItemByUnique()to the base picker context for accessing selected item data
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/documents/documents/components/input-document/input-document.context.ts | Implements variant-aware name resolution by overriding _requestItemName() to use UmbDocumentItemDataResolver |
| src/Umbraco.Web.UI.Client/src/packages/core/picker-input/picker-input.context.ts | Refactors remove item confirmation to use new extensible _requestItemName() method and adds helper methods for accessing selected items |
andr317c
approved these changes
Nov 17, 2025
Contributor
andr317c
left a comment
andr317c
left a comment
There was a problem hiding this comment.
Looks good, tests good 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to Document Input gets the right variant name, not just the item.name.
Fixes both in Property Editor and in User Workspace — same code in both cases.
This problem:
