Migrations: Ensures Folder media type has a collection view on migration and moves last synched table to a pre-migration
#20743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyButland
reviewed
Nov 6, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Nice work @NillasKA - this works as expected.
I could replicate the first issue and can verify that this migration fixes it.
The second issue I couldn't replicate myself, but can see that moving this to a pre-migration is going to be necessary if there's a chance that something looks for this table prior to the main upgrade completing.
...o.Infrastructure/Migrations/Upgrade/V_17_0_0/EnsureDefaultMediaFolderHasDefaultCollection.cs
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Migrations/Upgrade/V_17_0_0/MigrateMediaFolder.cs
Outdated
Show resolved
Hide resolved
…x' into v17/add-migration-to-media-bugfix
AndyButland
approved these changes
Nov 6, 2025
AndyButland
pushed a commit
that referenced
this pull request
Nov 6, 2025
…ection & Last Synced Table not existing. (#20743) * Creating and adding new migration. And fixing another small bug. * Adding XML Header and renaming to a more clearly defined name
AndyButland
changed the title
Folder media type has a collection view on migration and moves last synched table to a pre-migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20517
This fixes 2 bugs.
Description
Added a migration that checks if the original media type "Folder" exists, and if it has a list view. If it doesn't, we add one.
The other bugfix is the Last Synced Table not existing. This resulted in the users not being able to login to do the migration. So i added the migration that adds this table, to the pre-migrations.
Thanks @nikolajlauridsen
Testing
To test this, grab a fresh V13 DB and point your V17 project to it.
Before this fix, the media data type called "Folder" wouldnt get a Collection. Now it does.