Entity Sign: Improve Firefox visibility and add focus support #20733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...raco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-base/tree-item-element-base.ts
Outdated
Show resolved
Hide resolved
nielslyngsoe
approved these changes
Nov 13, 2025
nielslyngsoe
deleted the
v17/improvement/entity-sign-visible-in-firefox
branch
Member
|
This is still not working for me on RC2 I'm afraid! 
I can see it works in Edge: 
|
Member
|
This has been cherry-picked to take part in the RC3 of v.17.0 |
iOvergaard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20687
Summary
This PR updates the positioning logic for the Entity Sign bundle to ensure that sign icons are visible in Firefox.
Previously, due to the use of position-anchor (not supported in Firefox), the entire element was clipped and signs were not visible.
Changes
Result
Signs are now visible across all browsers.
Improved accessibility via keyboard focus interaction.
Note: In Firefox, hover/focus dropdowns are still not available due to Shadow DOM interaction issues.