Rich text editor: Treat an "empty" value as a non-value (closes #20454) #20719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjac
changed the title
AndyButland
approved these changes
Nov 3, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Looks good to me. I've tested the fix and can see the problem resolved. You mentioned that you couldn't see this problem for invariant content which was odd, as I could, but it's resolved by these updates. Just for verification I extended the tests you had written to handle both invariant and variant content.
AndyButland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #20454
Description
In V13, the RTE would allow for rendering fallback values. In V15+, after the introduction of blocks in the RTE, this is no longer the case.
See the linked issue for a detailed description and steps to reproduce + test.
Note that I have only been able to reproduce the issue for variant documents.
Also note that I have chosen to make an empty paragraph tag count as "no value" - this is what the RTE stores in the
markupproperty when the editor removes all content from the RTE.