Skip to content

Conversation

@creativesuspects
Copy link

Prerequisites

  • I have added steps to test this contribution in the description below

This PR fixes issue #20683

Description

  1. Create CSS-file in /wwwroot/block-styles.css
  2. Create a new Document Type (Element Type) called "Test Block", add a textstring-property called "Heading"
  3. Create a new Data Type called "Block List with Styles", add a block using the content type from step 2. Configure it to use the block-style.css file as "Custom styleheet".
  4. Add a new Document type allowed at root and place the `Block List with Styles´-data type to the new document type.
  5. Create a new content node of the new document type and add a Test Block to the Block List editor.

Notice that the request to /wwwroot/block-styles.css now has a cache buster.

Before
image

After
image

Copilot AI review requested due to automatic review settings October 30, 2025 11:03
@github-actions
Copy link

Hi there @creativesuspects, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@creativesuspects creativesuspects changed the base branch from main to v13/main October 30, 2025 11:05
@creativesuspects creativesuspects changed the title V13/bugfix/20683 cache buster for block list stylesheets #20683 cache buster for block list stylesheets Oct 30, 2025
@creativesuspects creativesuspects changed the title #20683 cache buster for block list stylesheets #20683 Added cache buster for block list stylesheets Oct 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Umbraco CMS from version 13.8.0-rc to 13.10.0-rc with multiple bug fixes and improvements across the codebase. The changes focus on performance optimizations, security enhancements, bug fixes in the UI and backend, and improved testing.

  • Version bump from 13.8.0-rc to 13.10.0-rc
  • Performance optimization for member login via UpdateLoginPropertiesAsync method
  • Security improvements for external login provider changes and timing attack mitigation
  • Multiple UI bug fixes and improvements in the backoffice

Reviewed Changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Show a summary per file
File Description
version.json Version bump from 13.8.0-rc to 13.10.0-rc
src/Umbraco.Infrastructure/Security/MemberUserStore.cs Added optimization to avoid full member save on login property updates
src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs Added UpdateLoginPropertiesAsync method for efficient login property updates
src/Umbraco.Web.BackOffice/Controllers/AuthenticationController.cs Added timed scope to mitigate timing attacks on login attempts
src/Umbraco.Web.BackOffice/Security/BackOfficeExternalLoginProviders.cs Added logic to invalidate sessions when external login providers change
src/Umbraco.Web.BackOffice/NotificationHandlers/ExternalLoginProviderStartupHandler.cs New handler to process external login provider changes at startup
src/Umbraco.Web.Website/Cache/PartialViewCacheInvalidators/MemberPartialViewCacheInvalidator.cs New implementation for clearing member-specific partial view cache
src/Umbraco.Web.Website/Extensions/HtmlHelperRenderExtensions.cs Refactored cache key generation to support testing and validation
src/Umbraco.Infrastructure/PropertyEditors/RichTextPropertyIndexValueFactory.cs Fixed HTML stripping to preserve word boundaries at <br> tags
src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TagRepository.cs Fixed tag comparison to be case-insensitive
src/Umbraco.Web.BackOffice/Controllers/MacroRenderingController.cs Added support for GUID-based page IDs in macro rendering
src/Umbraco.PublishedCache.NuCache/PublishedSnapshotService.cs Added background thread support for cache rebuilding
src/Umbraco.Web.UI.Client/src/views/propertyeditors/datepicker/datepicker.controller.js Fixed undefined property reference
tests/* Added multiple unit and integration tests for new functionality

@AndyButland AndyButland changed the title #20683 Added cache buster for block list stylesheets Backoffice Caching: Added cache buster for block list stylesheets (closes #20683) Oct 30, 2025
@AndyButland AndyButland changed the base branch from v13/main to v13/dev October 30, 2025 11:46
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @creativesuspects - all works as expected. Will include this for 13.12.

@AndyButland AndyButland merged commit 8110b80 into umbraco:v13/dev Oct 30, 2025
24 of 25 checks passed
AndyButland pushed a commit that referenced this pull request Oct 30, 2025
…oses #20683) (#20686)

Fixed, added cache buster to Block List Editor stylesheets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants