-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Backoffice Caching: Added cache buster for block list stylesheets (closes #20683) #20686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backoffice Caching: Added cache buster for block list stylesheets (closes #20683) #20686
Conversation
|
Hi there @creativesuspects, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Umbraco CMS from version 13.8.0-rc to 13.10.0-rc with multiple bug fixes and improvements across the codebase. The changes focus on performance optimizations, security enhancements, bug fixes in the UI and backend, and improved testing.
- Version bump from 13.8.0-rc to 13.10.0-rc
- Performance optimization for member login via
UpdateLoginPropertiesAsyncmethod - Security improvements for external login provider changes and timing attack mitigation
- Multiple UI bug fixes and improvements in the backoffice
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Version bump from 13.8.0-rc to 13.10.0-rc |
| src/Umbraco.Infrastructure/Security/MemberUserStore.cs | Added optimization to avoid full member save on login property updates |
| src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberRepository.cs | Added UpdateLoginPropertiesAsync method for efficient login property updates |
| src/Umbraco.Web.BackOffice/Controllers/AuthenticationController.cs | Added timed scope to mitigate timing attacks on login attempts |
| src/Umbraco.Web.BackOffice/Security/BackOfficeExternalLoginProviders.cs | Added logic to invalidate sessions when external login providers change |
| src/Umbraco.Web.BackOffice/NotificationHandlers/ExternalLoginProviderStartupHandler.cs | New handler to process external login provider changes at startup |
| src/Umbraco.Web.Website/Cache/PartialViewCacheInvalidators/MemberPartialViewCacheInvalidator.cs | New implementation for clearing member-specific partial view cache |
| src/Umbraco.Web.Website/Extensions/HtmlHelperRenderExtensions.cs | Refactored cache key generation to support testing and validation |
| src/Umbraco.Infrastructure/PropertyEditors/RichTextPropertyIndexValueFactory.cs | Fixed HTML stripping to preserve word boundaries at <br> tags |
| src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TagRepository.cs | Fixed tag comparison to be case-insensitive |
| src/Umbraco.Web.BackOffice/Controllers/MacroRenderingController.cs | Added support for GUID-based page IDs in macro rendering |
| src/Umbraco.PublishedCache.NuCache/PublishedSnapshotService.cs | Added background thread support for cache rebuilding |
| src/Umbraco.Web.UI.Client/src/views/propertyeditors/datepicker/datepicker.controller.js | Fixed undefined property reference |
| tests/* | Added multiple unit and integration tests for new functionality |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @creativesuspects - all works as expected. Will include this for 13.12.
Prerequisites
This PR fixes issue #20683
Description
Notice that the request to /wwwroot/block-styles.css now has a cache buster.
Before

After
