Webhooks: Reverts nullability update to continue to allow derived classes to create null payloads #20660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into release/17.0
…into release/17.0
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a nullability constraint on the ConvertNotificationToRequestPayload method to restore flexibility for derived webhook classes. The change allows custom webhook implementations to return null payloads when needed, rather than forcing them to always provide a non-null object.
Key Changes
- Modified the return type of
ConvertNotificationToRequestPayloadfromobjecttoobject?to permit null return values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Addresses comment raised here: #15927 (comment) on #15927
Description
As noted in the linked comment, we don't need to prevent custom webhook implementations from providing null payloads if they want to.