Webhooks: Register OutputExpansionStrategy for webhooks if Delivery API is not enabled (closes #20272) #20559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yapi is not enabled
AndyButland
changed the title
AndyButland
approved these changes
Oct 20, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Looks reasonable to me @Migaroez. I've tested to replicate the original issue and confirmed with this code in place I don't see the problem, and the webhook is fired as expected. I left a few comments inline to consider, but other than that, seems good to me.
src/Umbraco.Cms.Api.Common/Rendering/ElementOnlyOutputExpansionStrategy.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Common/Rendering/ElementOnlyOutputExpansionStrategy.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Delivery/DependencyInjection/UmbracoBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Delivery/DependencyInjection/UmbracoBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
AndyButland
changed the title
AndyButland
pushed a commit
that referenced
this pull request
Oct 22, 2025
…PI is not enabled (#20559) * Register slimmed down OutputExpansionStrategy for webhooks if deliveryapi is not enabled * PR review comment resolution
Migaroez
added a commit
that referenced
this pull request
Nov 3, 2025
…tegy for webhooks if Delivery API is not enabled)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixs #20272
Description
This a non breaking attempt to fix the above issue. It might not be the ideal solution, so I am open to all feedback.