Segments: Adds deprecation notices to AllowNonExistingSegmentsCreation
#20413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds deprecation notices for segment creation settings that will be replaced by a client-side extension in V19. The changes mark two properties as obsolete and add a client-side deprecation warning when the feature is disabled.
- Adds
[Obsolete]attributes to segment creation properties in both C# model classes - Implements client-side deprecation warning when
allowNonExistingSegmentsCreationis set to false
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| document-workspace.context.ts | Adds client-side deprecation warning when segment creation is disabled |
| SegmentSettings.cs | Marks AllowCreation property as obsolete with deprecation message |
| DocumentConfigurationResponseModel.cs | Marks AllowNonExistingSegmentsCreation property as obsolete with deprecation message |
...braco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace.context.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
DocumentConfigurationResponseModel#AllowNonExistingSegmentsCreationas well as theSegmentSettings#AllowCreationhave been deprecated. They will be replaced by a yet non-existing client-side extension in V19.