AllowEditInvariantFromNonDefault : Fix property write guard to use correct variant ID (closes #20250) #20277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the use of propertyVariantId with _datasetVariantId in the property write guard check to ensure permissions are evaluated for the correct variant.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the property write guard logic where the wrong variant ID was being passed as a parameter, causing incorrect permission checks for content properties.
- Corrects the fourth parameter of
isPermittedForVariantAndPropertyto use the dataset variant ID instead of the property variant ID
....Client/src/packages/content/content/global-components/content-workspace-property.element.ts
Show resolved
Hide resolved
AndyButland
approved these changes
Sep 25, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Works as expected now, thanks @madsrasmussen. Do you consider this a regression and one we should merge in for 16.3 please?
AndyButland
deleted the
v16/bugfix/Non-variant-property-not-disabled-in-other-languages-than-default
branch
Contributor
|
Cherry-picked for 16.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20250