-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Unattended install: Added the ability to set the telemetry level #20249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unattended install: Added the ability to set the telemetry level #20249
Conversation
|
Hi there @KaasKop97, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @KaasKop97 - looks a useful addition.
I had a quick look over and spotted a couple of issues. If you are able to resolve these we should have time next week for a full review and test and consider merging this in.
src/Umbraco.Cms.Api.Management/Install/PostUnattendedInstallNotificationHandler.cs
Show resolved
Hide resolved
Added 'UnattendedTelemetryLevel' to 'UnattendedSettings' Renamed 'CreateUnattendedUserNotificationHandler' to 'PostUnattendedInstallNotificationHandler' Set the telemetry level in the unattended install notification handler
2a53c3d to
597314b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works nicely @KaasKop97 - thanks very much. I'll merge this in for Umbraco 17 and prepare a documentation update for the new option.
First though just going to prepare an update to add this to the dotnet new template as well, to align with the other unattended options.
|
Have verified the template options creating a project both with the CLI and Visual Studio. Docs PR for this update is here: umbraco/UmbracoDocs#7450 |
What did I do
I added 'UnattendedTelemetryLevel' to the unattended installer configuration, I used the already existing unattended installer notification handler and renamed it to a better suiting more generic name so I could include the setting of telemetry level.
Also fixed some formatting and comments in the files I edited.
Why did I do it
I noticed I could set the telemetry level from the regular installer but not from an unattended installation.
I already applied a patch akin to this one in my own Umbraco project but I thought other people might also want the functionality to set the telemetry level from an unattended install hence this pull request.
How to test
Add the already present unattended installation settings and add a property in the map with "UnattendedTelemetryLevel" to either "Minimal", "Basic" or "Detailed" like so:
The unattended installer will now run and set the telemetry level to the value provided in the appsettings. If the level is not set in the appsettings it falls back to 'Detailed' like the regular installer.
If the pull request is merged I shall also update the documentation to match the functionality.