-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Tiptap: QA Added acceptance tests for regression issue #19763 #20226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds acceptance tests for regression issue #19763, which involves saving variant content nodes after removing embedded blocks in a Rich Text Editor (RTE). The test ensures that the functionality works correctly for multilingual content with embedded blocks.
- Adds a new acceptance test specifically targeting the regression scenario
- Tests the complete workflow of creating, adding blocks, and clearing content in TipTap editor
- Includes proper cleanup of test data
...co.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts
Outdated
Show resolved
Hide resolved
...co.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts
Show resolved
Hide resolved
nhudinh0309
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some comments
...co.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts
Outdated
Show resolved
Hide resolved
...co.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts
Outdated
Show resolved
Hide resolved
...co.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts
Outdated
Show resolved
Hide resolved
...co.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts
Outdated
Show resolved
Hide resolved
...co.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts
Outdated
Show resolved
Hide resolved
...co.Tests.AcceptanceTest/tests/DefaultConfig/Content/RichTextEditor/ContentWithTiptap.spec.ts
Outdated
Show resolved
Hide resolved
nhudinh0309
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a small comment. You can merge it after ensuring this test passes on the pipeline.
No description provided.