Skip to content

Conversation

@nielslyngsoe
Copy link
Member

Ensures variant data that varies by segment and not by culture are handled as well and gets stored as a variant-Entry with culture, despite the cross existance of the value.

Copilot AI review requested due to automatic review settings September 18, 2025 16:42
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) September 18, 2025 16:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes handling of variant data that varies by segment but not by culture in Umbraco's content management system. The changes ensure that segment-specific variant entries are properly stored with culture information even when the property doesn't vary by culture.

  • Improves variant name display logic to handle empty/whitespace variant names gracefully
  • Adds logic to ensure segment variants are created for all cultures when properties vary by segment but not culture
  • Refactors data processing to handle segment-only variants correctly

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
workspace-split-view-variant-selector.element.ts Improves variant name display by checking for empty/whitespace variant names
content-detail-workspace-base.ts Adds logic to create segment variants across all cultures when needed
element-data-manager.ts Refactors data processing and improves segment filtering logic
content-data-manager.ts Adds clarifying comment for segment handling

@umbraco umbraco deleted a comment from Copilot AI Sep 18, 2025
@nielslyngsoe nielslyngsoe merged commit b35db9c into main Oct 2, 2025
26 of 27 checks passed
@nielslyngsoe nielslyngsoe deleted the v16/bugfix/correct-data-for-vary-by-segment branch October 2, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants