Workspace Actions: set attributes on the right element for label to work #20178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an accessibility issue with the Workspace Actions button by properly associating the label attribute with the correct HTML element. The change ensures that screen readers can properly identify the purpose of the dropdown button.
- Moved label attribute from nested
uui-symbol-moreelement to parentumb-entity-actions-dropdownelement - Relocated
data-markattribute for proper test identification
...re/workspace/components/workspace-entity-action-menu/workspace-entity-action-menu.element.ts
Show resolved
Hide resolved
leekelleher
approved these changes
Sep 18, 2025
leekelleher
deleted the
v16/bugfix/correct-label-for-workspace-actions
branch
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the label for Workspace Actions button