Tiptap RTE: Adds accessibility attributes for RTE input #20157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 16, 2025 10:31
leekelleher
requested changes
Sep 16, 2025
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
@OskarKruger Thank you for the changes. I've left some comments on specific lines.
src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @leekelleher Thanks for the help! |
leekelleher
approved these changes
Sep 17, 2025
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Super, thanks @OskarKruger! 🚀
leekelleher
changed the title
This was referenced Oct 20, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added dynamic labels for TipTap RTE input fields using aria-labels as umb-tiptap does not automatically handle aria-labels like UUI components.