Skip to content

Conversation

@floede
Copy link
Contributor

@floede floede commented Sep 4, 2025

Prerequisites

  • [ x ] I have added steps to test this contribution in the description below

Description

As discussed with Niels Lyngsø, this introduces a custom property to adjust the top property for #headerColumn, with the existing value as fallback.

In property-layout.element.ts I have added --umb-property-layout-header-top as the default to set the top value for #headerColumn.

Copilot AI review requested due to automatic review settings September 4, 2025 12:50
@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Hi there @floede, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@floede
Copy link
Contributor Author

floede commented Sep 4, 2025

@nielslyngsoe This is the small change we've discussed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a custom CSS property --umb-property-layout-header-top to allow customization of the top positioning for the header column in property layouts. The change provides a way to override the default positioning while maintaining backward compatibility through CSS fallback values.

Key Changes:

  • Added a custom CSS property for controlling header column positioning
  • Maintained backward compatibility with existing default values
  • Applied the custom property to both default and sticky positioning scenarios

@emmagarland
Copy link
Contributor

Hi @floede

Thanks for your PR to fix an issue with the temp layout/custom property.

One of the Core Collaborators team is likely to review this as soon as possible - although as it sounds like you've already chatted to Niels about it too, which means HQ might review it first.

To avoid potential code duplication, if there is a related issue please can you add a comment relating to it?

Thanks again for your time and effort!

Best regards

Emma

@Matthew-Wise Matthew-Wise force-pushed the temp/layout-header-top-custom-property branch 2 times, most recently from 7c8846b to 31b6a20 Compare September 25, 2025 13:40
@Matthew-Wise Matthew-Wise force-pushed the temp/layout-header-top-custom-property branch from 31b6a20 to 926259b Compare September 26, 2025 07:34
@Matthew-Wise Matthew-Wise merged commit fc60b5b into umbraco:main Sep 26, 2025
27 checks passed
@Matthew-Wise
Copy link
Contributor

Sorry for the delay in merging this @floede thank you for your work!

@lauraneto lauraneto changed the title Temp/layout header top custom property Layout header top custom property Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants