-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Layout header top custom property #20080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout header top custom property #20080
Conversation
|
Hi there @floede, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
@nielslyngsoe This is the small change we've discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a custom CSS property --umb-property-layout-header-top to allow customization of the top positioning for the header column in property layouts. The change provides a way to override the default positioning while maintaining backward compatibility through CSS fallback values.
Key Changes:
- Added a custom CSS property for controlling header column positioning
- Maintained backward compatibility with existing default values
- Applied the custom property to both default and sticky positioning scenarios
...b.UI.Client/src/packages/core/property/components/property-layout/property-layout.element.ts
Show resolved
Hide resolved
|
Hi @floede Thanks for your PR to fix an issue with the temp layout/custom property. One of the Core Collaborators team is likely to review this as soon as possible - although as it sounds like you've already chatted to Niels about it too, which means HQ might review it first. To avoid potential code duplication, if there is a related issue please can you add a comment relating to it? Thanks again for your time and effort! Best regards Emma |
7c8846b to
31b6a20
Compare
31b6a20 to
926259b
Compare
|
Sorry for the delay in merging this @floede thank you for your work! |
Prerequisites
Description
As discussed with Niels Lyngsø, this introduces a custom property to adjust the top property for #headerColumn, with the existing value as fallback.
In property-layout.element.ts I have added --umb-property-layout-header-top as the default to set the top value for #headerColumn.