Content Type Designer tabs sorting improvement #20074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkspace/views/design/content-type-design-editor.element.ts Co-authored-by: Copilot <[email protected]>
nielslyngsoe
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves tab sorting functionality in the Content Type Designer by fixing several issues with tab sorting behavior and user interface elements.
- Excludes the root tab from sorting operations to prevent unwanted behavior
- Adds proper pointer event handling for better drag-and-drop interaction
- Ensures proper sort order is maintained when merging containers from different inheritance levels
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| content-type-design-editor.element.ts | Updates tab sorting configuration, fixes CSS class names, improves UI interaction handling, and adds localization |
| content-type-structure-manager.class.ts | Ensures owner containers maintain correct sort order when merging inherited containers |
| content-type-container-structure-helper.class.ts | Adds missing sort operation for merged child containers |
...c/packages/content/content-type/workspace/views/design/content-type-design-editor.element.ts
Outdated
Show resolved
Hide resolved
...c/packages/content/content-type/workspace/views/design/content-type-design-editor.element.ts
Show resolved
Hide resolved
auto-merge was automatically disabled
September 4, 2025 08:13
Pull request was converted to draft
…to v16/bugfix/content-type-designer-tabs-sorting
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor.element.ts
madsrasmussen
approved these changes
Sep 5, 2025
nielslyngsoe
deleted the
v16/bugfix/content-type-designer-tabs-sorting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs sorting turns out to be slightly annoying and not working in some cases. So I have fixed that here.
Please review this first: #20073