Introducing signs to variants #20053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to move logic to DocumentPresentationFactory.cs
…eadable (hopefully)
Zeegaan
requested changes
Sep 3, 2025
src/Umbraco.Cms.Api.Management/Factories/DocumentPresentationFactory.cs
Outdated
Show resolved
Hide resolved
lauraneto
changed the title
This was referenced Oct 20, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR Makes it so the SignProviders
HasPendingChangesSignProvider&HasScheduleSignProviderapplies its signs to the given variants of the the document. The purpose of this, is to make it easier to tell which variant of the document has theese specifications.A part of this PR is also moving some of the code, to the respective factories, due to it being more logical to handle these variant changes within the factories where the variants are being created. For future reference, a restructuring of the other sign providers, to also make use of factories could be a good change, since some of them still has their uses applied in controllers.¨
To accompany this, i have also reinstated some constructors that has been marked as obsolete - As far as i could tell, these have not been included in any releases and therefore it shouldn't be deemed as a breaking change.
The
HasScheduleSignProviderwas tougher than i expected, to apply these signs to its variants, therefore the code is a slight bit more complex and includes 2 DB Calls, please take a solid look at that, and suggest any refactoring if applicable.Have a great day 😄