v16 QA Updated flaky tests #20052
Merged
v16 QA Updated flaky tests #20052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant and unnecessary method calls in Umbraco acceptance tests to fix flaky test behavior. The changes focus on eliminating duplicate save/publish actions and removing unused parameters that were causing test instability.
- Removes duplicate
clickContainerSaveAndPublishButton()calls in media picker tests - Removes unused boolean parameters from data type creation methods
- Adds missing element selection step in block list settings test
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ContentWithMediaPicker.spec.ts | Removes duplicate container save/publish button clicks to prevent double submissions |
| ContentWithBlockList.spec.ts | Removes unused boolean parameters from data type creation and adds missing element selection |
| ContentWithBlockGrid.spec.ts | Removes unused boolean parameter from document type creation method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.