Removes 'rollup' and 'glob' from NOTICES.txt #20043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the file only contains first-party mentions
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the NOTICES.txt file by removing obsolete third-party software attributions and improving the clarity of the introductory notice. The changes reflect updates to the project's dependency structure following previous changes (referenced as #19716).
Key changes:
- Enhanced the introductory notice to clarify the scope and limitations of third-party dependency listings
- Removed attributions for build tools (Rollup and related plugins) that are no longer project dependencies
- Removed attribution for the Glob library which is no longer used
leekelleher
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the third-party notices in the
NOTICES.txtfile to improve clarity and remove outdated entries. The most important changes include clarifying the scope of third-party dependencies and cleaning up the list of attributions.Documentation improvements:
Third-party attribution cleanup:
The following notices no longer apply with #19716:
Globlibrary, which is no longer listed as a dependency.Rollup,Rollup Plugins,Rollup-plugin-esbuild, andRollup-plugin-import-css) from the notice file, indicating these are no longer relevant dependencies.