Workspace View Manifest Overrides #20033
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables Workspace View Manifest Overrides functionality to allow Collection Data-Type configurations to alter the Workspace View appearance. The implementation introduces a collection manager system that applies data type configuration overrides to workspace view manifests, enabling customization of collection workspace views through configuration.
Key Changes:
- Introduced
UmbContentCollectionManagerto handle collection configuration and manifest overrides - Refactored collection workspace context to use the new manager pattern
- Added support for passing overrides through workspace editor components
- Consolidated collection view manifests into a shared location
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/property-editors/collection/property-editor-ui-collection.element.ts | Fixed context handling and lifecycle management in collection property editor |
| src/Umbraco.Web.UI.Client/src/packages/content/content/collection/manager/content-collection-manager.controller.ts | New collection manager that handles configuration and manifest overrides |
| src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-editor/workspace-editor.context.ts | Enhanced workspace editor context to support manifest overrides with complex merging logic |
| src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts | Integrated collection manager into content workspace base |
| Multiple workspace files | Added override support and updated collection alias access patterns |
....UI.Client/src/packages/property-editors/collection/property-editor-ui-collection.element.ts
Outdated
Show resolved
Hide resolved
....UI.Client/src/packages/property-editors/collection/property-editor-ui-collection.element.ts
Outdated
Show resolved
Hide resolved
...I.Client/src/packages/core/workspace/components/workspace-editor/workspace-editor.context.ts
Show resolved
Hide resolved
...ent/src/packages/content/content/collection/manager/content-collection-manager.controller.ts
Show resolved
Hide resolved
…tion/property-editor-ui-collection.element.ts Co-authored-by: Copilot <[email protected]>
Mostly fixing up the imports and removal of `elementName` constants
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Tested out, works as expected! 🚀
I noticed that the Collection property-editor UI was stuck in a loading state. Turned out that the #workspaceContext wasn't being set. I've fixed that. 👍 Also, I did a sweep of various import statements, etc. all minor things.
I'm very happy to see this feature developed, especially after struggling for a workable solution last year. 😁
|
This pull request has been mentioned on Umbraco community forum. There might be relevant details there: https://forum.umbraco.com/t/change-in-workspace-settings-for-listview-v16-arent-shown/4331/3 |
Unrelated to Tiptap, but causes data-types to throw an error. Bug introduced in PR #20033
* Updates RTE mock data * UFM: Adds fallback for "monospace" font-family * Removes the Font Family/Sizes Menu extension This feature is not ready yet. * Tighten up Tiptap config buttons style * Fixes bug with Collections context-token Unrelated to Tiptap, but causes data-types to throw an error. Bug introduced in PR #20033 * Deprecations for v17
Fixes #16633
Fixes #18986
Enables doing a local override of manifest properties.
And utilises this to enable the Collection Data-Type configurations to alter the Workspace View appearance.
Example with this PR these configuration:
Results in this collection workspace view:
