-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add timestamps to cache entries and server events #19976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timestamps to cache entries and server events #19976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds timestamp tracking to cache entries and server events in the Umbraco management API frontend. The changes implement client-side timestamping to track when events and cache entries are created.
Key Changes
- Added
clientTimestampfield to server event models and automatically populated it when events are received - Added
timestampfield to all cache entry models (item cache, detail cache, and in-flight request cache) - Renamed cache classes for better consistency and clarity
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| types.ts | Added clientTimestamp field to server event model interface |
| server-event.context.ts | Modified event handler to inject client timestamp when receiving server events |
| management-api/item/cache.ts | Added timestamp to item cache entries and renamed interface for clarity |
| management-api/inflight-request/cache.ts | Added timestamp to in-flight request cache and restructured cache entries |
| management-api/detail/cache.ts | Added timestamp to detail cache entries and renamed interface |
| detail-data.request-manager.ts | Updated to use renamed in-flight request cache class and handle new cache structure |
| document-type-detail.server.request-manager.ts | Updated import and instantiation of renamed cache class |
| data-type-detail.server.request-manager.ts | Updated import and instantiation of renamed cache class |
Add a timestamp to server events and client cache entries