V17 - Removed obsoleted code from Cms.Api #19963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NillasKA
changed the title
* Removing obsoleted constructors from AncestorsSelector.cs * Removing obsoleted constructors from ChildrenSelector.cs * Removing obsoleted code from DescendantsSelector.cs * Removing obsoleted code from RequestCultureService.cs * Removing obsoleted code from QueryOptionBase.cs
NillasKA
changed the title
… dependencies & IBackOfficeApplicationManager.cs
AndyButland
requested changes
Aug 22, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Looks good - just a little further clean-up we can do that I've noted inline.
src/Umbraco.Cms.Api.Management/Controllers/Document/ByKeyDocumentController.cs
Outdated
Show resolved
Hide resolved
AndyButland
requested changes
Aug 22, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Looks mostly good to me now, but could you just check over and remove the ActivatorUtilitiesConstructor from all controllers where you have cleaned up to only have one constructor left please. It doesn't really do any harm, but it's not necessary unless there is more than one constructor, so we can remove it.
src/Umbraco.Cms.Api.Management/Controllers/Document/ValidateCreateDocumentController.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Management/Controllers/Document/ValidateUpdateDocumentController.cs
Outdated
Show resolved
Hide resolved
...Umbraco.Cms.Api.Management/Controllers/DocumentType/Item/SearchDocumentTypeItemController.cs
Outdated
Show resolved
Hide resolved
AndyButland
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A ton of obsoleted code, that has been scheduled for removal in Umbraco 17 has been removed, and their usages has been adjusted (If there was any)
Mainly this PR is the removal of obsoleted code from the Umbraco.Cms.Api.Common