Skip to content

Conversation

@nhudinh0309
Copy link
Contributor

@nhudinh0309 nhudinh0309 commented Aug 19, 2025

This PR adds the acceptance tests for the PR: #19621
And it also contains the following PRs that have been independently reviewed and tested:

nhudinh0309 and others added 30 commits August 19, 2025 21:21
#20020)

* Add entity action test to get unique and entity type

* update test entity action

---------

Co-authored-by: Lan Nguyen Thuy <[email protected]>
nhudinh0309 and others added 10 commits September 26, 2025 21:14
#20213)

* Property Editor: tests for create and using custom property editor

* Update tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/PropertyEditorTest.spec.ts

Co-authored-by: Nhu Dinh <[email protected]>

* Update tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/PropertyEditorTest.spec.ts

Co-authored-by: Nhu Dinh <[email protected]>

* Update tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/PropertyEditorTest.spec.ts

Co-authored-by: Nhu Dinh <[email protected]>

* update review from Nhu

* Update tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/CustomPropertyEditor.spec.ts

Co-authored-by: Nhu Dinh <[email protected]>

* Update tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/CustomPropertyEditor.spec.ts

Co-authored-by: Nhu Dinh <[email protected]>

* fix comment from Nhu

---------

Co-authored-by: Lan Nguyen Thuy <[email protected]>
Co-authored-by: Nhu Dinh <[email protected]>
@nhudinh0309 nhudinh0309 changed the title V16 QA Added tests for readOnlyGuard rules Extension Registry: QA Added acceptance tests for readOnlyGuards rule, entity action and custom property editor Sep 29, 2025
Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments

Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhudinh0309 nhudinh0309 enabled auto-merge (squash) October 6, 2025 09:11
@nhudinh0309 nhudinh0309 merged commit 84fb1f4 into main Oct 6, 2025
24 of 25 checks passed
@nhudinh0309 nhudinh0309 deleted the v16/QA/read-only-guard-tests branch October 6, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants