-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Extension Registry: QA Added acceptance tests for readOnlyGuards rule, entity action and custom property editor #19939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#20020) * Add entity action test to get unique and entity type * update test entity action --------- Co-authored-by: Lan Nguyen Thuy <[email protected]>
#20213) * Property Editor: tests for create and using custom property editor * Update tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/PropertyEditorTest.spec.ts Co-authored-by: Nhu Dinh <[email protected]> * Update tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/PropertyEditorTest.spec.ts Co-authored-by: Nhu Dinh <[email protected]> * Update tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/PropertyEditorTest.spec.ts Co-authored-by: Nhu Dinh <[email protected]> * update review from Nhu * Update tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/CustomPropertyEditor.spec.ts Co-authored-by: Nhu Dinh <[email protected]> * Update tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/CustomPropertyEditor.spec.ts Co-authored-by: Nhu Dinh <[email protected]> * fix comment from Nhu --------- Co-authored-by: Lan Nguyen Thuy <[email protected]> Co-authored-by: Nhu Dinh <[email protected]>
andr317c
requested changes
Oct 6, 2025
Contributor
andr317c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few comments
tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/ReadOnlyGuardRules.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/ReadOnlyGuardRules.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/RetrieveAction.spec.ts
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/RetrieveAction.spec.ts
Show resolved
Hide resolved
andr317c
approved these changes
Oct 6, 2025
Contributor
andr317c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the acceptance tests for the PR: #19621
And it also contains the following PRs that have been independently reviewed and tested: