Skip to content

Conversation

@idseefeld
Copy link
Contributor

Prerequisites

This PR fixes: #19909

Run test. Result should be:
19909-test-results

Copilot AI review requested due to automatic review settings August 13, 2025 14:23
@github-actions
Copy link

Hi there @idseefeld, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @idseefeld - good catches and will be good to get these tests running again. Must admit I have no idea why those two cases for the slider test weren't running, but I also can see they aren't.

I left a new minor comments really just for clean-up.

idseefeld and others added 3 commits August 14, 2025 21:00
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @idseefeld - I'll merge this in now when the checks have passed.

@AndyButland AndyButland changed the title fix some test which are not running Fix and enable some unit tests which are not running locally or on pipeline builds Aug 15, 2025
@AndyButland AndyButland enabled auto-merge (squash) August 15, 2025 06:56
@AndyButland AndyButland merged commit e2d7bb6 into umbraco:main Aug 15, 2025
25 checks passed
@idseefeld idseefeld deleted the v16/19909-fix-some-tests branch August 15, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some tests do not run

2 participants